[Lldb-commits] [lldb] r276795 - Check both private & public states to decide if you need to halt before killing.

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 28 02:37:11 PDT 2016


On 27 July 2016 at 23:39, Jim Ingham <jingham at apple.com> wrote:
>
> Yes, I see.
>
> This change always checks public state running, so all the flips from run to stopped in the private state thread will have no effect on all the modes of running except expression evaluation.
>
> The change as is is better than what was there before, even though it doesn't handle this case.  This check will fix the case where you have an expression that stalls and you go to kill the process (you have to be using a UI to do this, since otherwise you'd have to interrupt the expression to type "kill".)  Before this change, Destroy would do nothing in this case.  That's much more common than happening to be in the
>
> I have other things on my plate right now, but I filed:
>
> https://llvm.org/bugs/show_bug.cgi?id=28742
>
> to remind myself to go back and make this better.
>

Thanks.


More information about the lldb-commits mailing list