[Lldb-commits] [lldb] r276795 - Check both private & public states to decide if you need to halt before killing.
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Wed Jul 27 10:08:19 PDT 2016
On 27 July 2016 at 17:41, Jim Ingham <jingham at apple.com> wrote:
> If you go to halt a thread whose private state is running, and by the time you get to halting it the private state has gone from running to stopped then the code doing the halt will declare victory, since that's what it was trying to do. If it was still running, then it will have to interrupt. I don't see how this will be flakey.
This case is fine. The tricky part is the opposite:
- we check the private state, see that it is stopped and decide that
we have nothing to do
- meanwhile, the private state flips back to running (e.g. because it
was just temporarily stopped while it was stepping over a breakpoint)
- RunThreadPlan carries on running oblivious to the fact that someone
tried to interrupt it
- process does not stop
More information about the lldb-commits