[Lldb-commits] [PATCH] D22294: Add functionality for rewriting symbols

[Francis Ricci via lldb-commits]

fjricci marked 3 inline comments as done.

================
Comment at: packages/Python/lldbsuite/test/lang/c/symbol_rewriter/TestSymbolRewriter.py:28
@@ +27,3 @@
+        # Clang does not rewrite dwarf debug info, so it must be stripped
+        subprocess.check_call(['strip', '-g', exe])
+
----------------
labath wrote:
> This is not going to work for remote targets on different architectures. If you don't need debug info, could you just avoid generating it in the first place (-g0 ?). Maybe then you would be able to get this working on windows as well.
> If it doesn't work, then we should wire up this call to go through the Makefile, as it already knows how to find the right toolchain for cross-compilation.
Unfortunately, the '-g0' override will only work for dwarf tests. However, based on TestWithLimitDebugInfo, it looks like we can skip the test for non-dwarf symbols (`@skipIf(debug_info=no_match(["dwarf"]))`). I think this is probably the cleanest way to go.


http://reviews.llvm.org/D22294