[Lldb-commits] [PATCH] D22231: Implement trampoline step-through for Windows-x86.
Stephane Sezer via lldb-commits
lldb-commits at lists.llvm.org
Mon Jul 11 12:37:46 PDT 2016
Sounds good. I can make a separate patch to make all the constructors
public if you think that's better. See http://reviews.llvm.org/D22230
for a patch that makes one of the constructors public.
Is this patch good to go in its current form then?
On Mon, Jul 11, 2016 at 12:21 PM, Jim Ingham <jingham at apple.com> wrote:
> jingham added a comment.
> Yes, that's sad. It needs to be done that way because the plan that organizes stepping "through" and provides a safety backstop if the step through runs away needs to push the sub-plans after it has been pushed. We could move all the stuff in the ThreadPlanStepThrough constructor to the DidPush method, then let the various GetStepThroughTrampolinePlan methods -> PushStepThroughTrampolinePlans. But it looks like we've already made a bunch of the ThreadPlan constructors public to work around this sort of problem, so we should probably just give in and make all the constructors public, and just document that you should preferentially call QueueThreadPlan if you are in a place where that's possible...
More information about the lldb-commits