[Lldb-commits] [PATCH] D22132: Support for OCaml native debugging

[Greg Clayton via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Just a few fixes and this will be ready.


================
Comment at: include/lldb/lldb-forward.h:147
@@ -146,2 +146,3 @@
 class   ObjectFileJITDelegate;
+class   OCamlASTContext;
 class   OperatingSystem;
----------------
You shouldn't have to add this into lldb-forward.h

================
Comment at: include/lldb/lldb-forward.h:368
@@ -366,2 +367,3 @@
     typedef std::weak_ptr<lldb_private::ObjectFileJITDelegate> ObjectFileJITDelegateWP;
+    typedef std::unique_ptr<lldb_private::OCamlASTContext> OCamlASTContextUP;
     typedef std::unique_ptr<lldb_private::OperatingSystem> OperatingSystemUP;
----------------
You shouldn't have to add this into lldb-forward.h

================
Comment at: source/Plugins/Language/OCaml/CMakeLists.txt:4
@@ +3,1 @@
+)
\ No newline at end of file

----------------
Add newline


http://reviews.llvm.org/D22132