[Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 13 20:44:02 PDT 2016


labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

The overall change looks good, but please also add a test which specifically tests for watchpoints at unaligned addresses. Last time I checked, we all watchpoint tests were passing (at least on android) even without this patch, so it looks like our tests coverage is not sufficient here.


http://reviews.llvm.org/D21280





More information about the lldb-commits mailing list