[Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Thu May 26 03:43:58 PDT 2016
labath added a comment.
Zachary, Todd, you added these in http://reviews.llvm.org/D3929. I know it's a long time, but do you recall what was the original motivation for that?
In light of the issue in http://reviews.llvm.org/D20671, I've experimenting with compiling lldb with exceptions enabled, and this code here is interfering with the standard llvm logic for enabling them (LLVM_ENABLE_EH). Enabling this should not make any difference in the common case, as llvm already adds one set of exception-disabling flags if you don't specify the flag I mentioned (llvm/cmake/modules/AddLLVM.cmake).
So, unless we know of a concrete use case where this is needed, I think we should remove it.
More information about the lldb-commits