[Lldb-commits] [PATCH] D20567: Avoid using stdio in TestVirtual
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Tue May 24 10:04:07 PDT 2016
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/lang/cpp/virtual/TestVirtual.py:64
@@ +63,3 @@
+ self.assertTrue(golden.IsValid(), "Encountered an error reading the process's golden variable")
+ golden_str = str(golden)
+ self.assertTrue("c_as_C" in golden_str)
> Are we relying on std::string data formatters working here? Seems like a dangerous change as we would require any new ports of LLDB to have std::string formatters working or this test will fail?
That did not occur to me. Would shoving the data into a `char *` be acceptable?
More information about the lldb-commits