[Lldb-commits] [PATCH] D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache

[Oleksiy Vyalov via lldb-commits]

ovyalov added a comment.

In http://reviews.llvm.org/D20548#437862, @clayborg wrote:

> At some point we should probably make a host layer call like:
>
> const char *const char *Host::GetIllegalFilenameCharacters();" so that each host can determine the correct thing for the current host. Then FileSpec can be updated to use this function handle this with a method like "void FileSpec::NormalizePathForHost()". This will probably need to be done elsewhere.


I like this idea of generalizing illegal symbols handling on per-platform basis - since Pavel mentioned that 1..31 range of symbols is forbidden in Windows filenames we may have a method like bool Host::IsIllegalFilenameCharacter(char) to tell whether symbol is illegal on this platform.


http://reviews.llvm.org/D20548