[Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Fri May 20 05:39:22 PDT 2016


labath added inline comments.

================
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:39
@@ +38,3 @@
+    int regset = NT_PRSTATUS;
+    Error error = NativeProcessLinux::PtraceWrapper(PTRACE_GETREGSET, tid, &regset, &ioVec, sizeof_native_regs_struct);
+    HostInfo::ArchitectureKind kind = HostInfo::eArchKindDefault; // same bitness this process
----------------
labath wrote:
> nitesh.jain wrote:
> > Ptrace call with ptrace request "PTRACE_GETREGSET"  is failing for MIPS. We are currently investigating the reason for the failure. I will let you know asap.
> > 
> > Thanks
> Thanks for checking it out. I'll hold this for now.
> 
> Out of curiosity, what is errno being set to after this? Also, in which scenario does this happen (64->64 or 64->32, 32->32)?
Also, what is the kernel version you are using? NT_PRSTATUS was apparently added in 3.13, although I'm not sure if all the all the necessary pieces were there already -- (it may have been enabled slightly later).


http://reviews.llvm.org/D20368





More information about the lldb-commits mailing list