[Lldb-commits] [lldb] r269025 - Fix race in TestExitDuringStep and unify pseudo_barrier handling

[Pavel Labath via lldb-commits]

Hi,

so I think this is our old "compiler generates unpredictable number of
source locations for a line" friend again, which got triggered by a
random code reshuffle. Assuming the test still passes for you after
that, can you prepare a change to remove the "num_expected_locations =
1" from the relevant lines?

If that doesn't fix it, then we'll need to think harder about this.

pl

On 10 May 2016 at 21:25, Ed Maste <emaste at freebsd.org> wrote:
> On 10 May 2016 at 03:54, Pavel Labath via lldb-commits
> <lldb-commits at lists.llvm.org> wrote:
>> Author: labath
>> Date: Tue May 10 02:54:25 2016
>> New Revision: 269025
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=269025&view=rev
>> Log:
>> Fix race in TestExitDuringStep and unify pseudo_barrier handling
>
> After this change TestThreadExit is failing on FreeBSD 10 with:
> ...
>   File "/tank/emaste/src/llvm/tools/lldb/packages/Python/lldbsuite/test/functionalities/thread/thread_exit/TestThreadExit.py",
> line 36, in test
>     bp3_id = lldbutil.run_break_set_by_file_and_line (self,
> "main.cpp", self.break_3, num_expected_locations=1)
>   File "/tank/emaste/src/llvm/tools/lldb/packages/Python/lldbsuite/test/lldbutil.py",
> line 342, in run_break_set_by_file_and_line
>     check_breakpoint_result (test, break_results, num_locations =
> num_expected_locations)
>   File "/tank/emaste/src/llvm/tools/lldb/packages/Python/lldbsuite/test/lldbutil.py",
> line 474, in check_breakpoint_result
>     test.assertTrue (num_locations == out_num_locations, "Expecting %d
> locations, got %d."%(num_locations, out_num_locations))
> AssertionError: False is not True : Expecting 1 locations, got 2.
> ...
>
> "breakpoint list" shows:
>
> 3: file = '/tank/emaste/src/llvm/tools/lldb/packages/Python/lldbsuite/test/functionalities/thread/thread_exit/main.cpp',
> line = 67, locations = 2
>   3.1: where = a.out`main + 1437 at main.cpp:67, address =
> 0x00000000004018bd, unresolved, hit count = 0
>   3.2: where = a.out`main + 1846 at main.cpp:67, address =
> 0x0000000000401a56, unresolved, hit count = 0