[Lldb-commits] [lldb] r268467 - You have to call setHasLoadedFieldsFromExternalStorage AFTER calling

[Jim Ingham via lldb-commits]

Author: jingham
Date: Tue May  3 19:06:23 2016
New Revision: 268467

URL: http://llvm.org/viewvc/llvm-project?rev=268467&view=rev
Log:
You have to call setHasLoadedFieldsFromExternalStorage AFTER calling
the field_begin that starts the copy or it won't do anything.

This causes failures, but only in complex apps, I haven't found
a reduced test case for this yet. 

<rdar://problem/21951798>

Modified:
    lldb/trunk/source/Symbol/ClangASTContext.cpp

Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTContext.cpp?rev=268467&r1=268466&r2=268467&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/ClangASTContext.cpp (original)
+++ lldb/trunk/source/Symbol/ClangASTContext.cpp Tue May  3 19:06:23 2016
@@ -2618,8 +2618,8 @@ GetCompleteQualType (clang::ASTContext *
                             external_ast_source->CompleteType(cxx_record_decl);
                             if (cxx_record_decl->isCompleteDefinition())
                             {
-                                cxx_record_decl->setHasLoadedFieldsFromExternalStorage (true);
                                 cxx_record_decl->field_begin();
+                                cxx_record_decl->setHasLoadedFieldsFromExternalStorage (true);
                             }
                         }
                     }