[Lldb-commits] [PATCH] D15067: Design building out of sources

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue May 3 08:28:01 PDT 2016


labath added a comment.

Good question. I don't really have an opinion on that... Is it just that single line? (this would be simpler if you uploaded the final version :) ). If it just that single line, then I think it's fine. If you also need to play with the ADDITIONAL_VERSIONS and such, then we should think about making a macro or doing something else to avoid code duplication (there is already a FIXME in scripts/Python/modules/readline mentioning the additional versions).


Repository:
  rL LLVM

http://reviews.llvm.org/D15067





More information about the lldb-commits mailing list