[Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

[Zachary Turner via lldb-commits]

Can't you just remove that line and let it inherit the minimum version from
LLVM?

On Sat, Apr 30, 2016 at 4:58 PM Kamil Rytarowski <n54 at gmx.com> wrote:

> krytarowski updated this revision to Diff 55729.
> krytarowski added a comment.
>
> Set minimal required CMake to 2.8.12.2 - fixes build on NetBSD with CMake
> 3.5.2
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D19685
>
> Files:
>   CMakeLists.txt
>   cmake/modules/LLDBStandalone.cmake
>
> Index: cmake/modules/LLDBStandalone.cmake
> ===================================================================
> --- cmake/modules/LLDBStandalone.cmake
> +++ cmake/modules/LLDBStandalone.cmake
> @@ -2,7 +2,7 @@
>  # standalone project, using LLVM as an external library:
>  if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
>    project(lldb)
> -  cmake_minimum_required(VERSION 2.8)
> +  cmake_minimum_required(VERSION 2.8.12.2)
>
>    option(LLVM_INSTALL_TOOLCHAIN_ONLY "Only include toolchain files in the
> 'install' target." OFF)
>
> Index: CMakeLists.txt
> ===================================================================
> --- CMakeLists.txt
> +++ CMakeLists.txt
> @@ -1,4 +1,4 @@
> -cmake_minimum_required(VERSION 2.8)
> +cmake_minimum_required(VERSION 2.8.12.2)
>
>  include(cmake/modules/LLDBStandalone.cmake)
>  include(cmake/modules/LLDBConfig.cmake)
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160501/a3bca7a0/attachment.html>