[Lldb-commits] [PATCH] D19540: Add support for displaying Java array types on Andorid

Oleksiy Vyalov via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 28 10:14:26 PDT 2016


ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:103
@@ +102,3 @@
+            AddCXXSynthetic(g_category, lldb_private::formatters::JavaArraySyntheticFrontEndCreator,
+                            "Java array synthetic children", ConstString("^.*\\[\\]&?$"),
+                            SyntheticChildren::Flags().SetCascades(true), true);
----------------
Could you define a constant for "^.*\\[\\]&?$" since it's used twice?


http://reviews.llvm.org/D19540





More information about the lldb-commits mailing list