[Lldb-commits] [PATCH] D19533: Introduce Connection::ReadAll and fix AdbClient

[Pavel Labath via lldb-commits]

labath updated this revision to Diff 55397.
labath added a comment.

Added proper handling of the timeout after retries, and moved the functionality into
Connection::Read. I have called the parameter read_full_buffer, as I think that better reflects
its intended use. I did not want to add a default value for it, since default values on virtual
functions can produce unexpected results. I've also had to increase the timeout in AdbClient,
since now it actually had a meaning (it seems that ReadAll was spinning in a loop also in case
the server was sending no data at all).  The patch has grown bigger, but this is mostly due to
me refactoring unit tests to promote code reuse.


http://reviews.llvm.org/D19533

Files:
  include/lldb/Core/Connection.h
  include/lldb/Core/ConnectionSharedMemory.h
  include/lldb/Host/posix/ConnectionFileDescriptorPosix.h
  source/Core/Communication.cpp
  source/Core/ConnectionSharedMemory.cpp
  source/Host/common/Editline.cpp
  source/Host/posix/ConnectionFileDescriptorPosix.cpp
  source/Plugins/Platform/Android/AdbClient.cpp
  unittests/Host/CMakeLists.txt
  unittests/Host/ConnectionFileDescriptorPosixTest.cpp
  unittests/Host/SocketTest.cpp
  unittests/Host/SocketUtil.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19533.55397.patch
Type: text/x-patch
Size: 24467 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160428/c19fe357/attachment-0001.bin>