[Lldb-commits] [PATCH] D19606: XFail TestLambdas.py on Windows after fixing some of the problems

[Adrian McCarthy via lldb-commits]

amccarth created this revision.
amccarth added a reviewer: spyffe.
amccarth added a subscriber: lldb-commits.

1.  Fixed semicolon placement in the lambda in the test itself.

2.  Fixed lldbinline tests in general so that we don't attempt tests on platforms that don't use the given type of debug info.  (For example, no DWO tests on Windows.)  This fixes one of the two failures on Windows.  (TestLambdas.py was the only inline test that wasn't XFailed or skipped on Windows.)

3.  Set the error string in `IRInterpreter::CanInterpret` so that the caller doesn't print `(null)` instead of an explanation.  I don't entirely understand the error, so feel free to suggest a better wording.

4.  XFailed the test on Windows.  The interpreter won't evaluate the lambda because the module has multiple function bodies.  I don't exactly understand why that's a problem for the interpreter nor why the problem arises only on Windows.




http://reviews.llvm.org/D19606

Files:
  packages/Python/lldbsuite/test/lang/cpp/lambdas/TestLambdas.py
  packages/Python/lldbsuite/test/lang/cpp/lambdas/main.cpp
  packages/Python/lldbsuite/test/lldbinline.py
  source/Expression/IRInterpreter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19606.55263.patch
Type: text/x-patch
Size: 4836 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160427/aa991195/attachment.bin>