[Lldb-commits] [PATCH] D19305: Use Process Plugin register indices when communicating with remote

[Francis Ricci via lldb-commits]

fjricci added a comment.

I can add a comment to the ReadRegister decl.

Alternatively, if you think it would be preferable, I could change the parameter name from reg_num to something more descriptive, like remote_reg_num or plugin_reg_num.

Or I could change ReadRegister to take a RegisterInfo instead of a register number, and that way it could select the appropriate ProcessPlugin regnum on its own, right when it generates the packet. This method actually might be most consistent with the rest of the changes in the patch.


http://reviews.llvm.org/D19305