[Lldb-commits] [lldb] r266417 - Fix ABISysV_s390x::GetArgumentValues

Ulrich Weigand via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 15 02:14:33 PDT 2016


Author: uweigand
Date: Fri Apr 15 04:14:32 2016
New Revision: 266417

URL: http://llvm.org/viewvc/llvm-project?rev=266417&view=rev
Log:
Fix ABISysV_s390x::GetArgumentValues

This routine contained a stray "return false;" making part of the code
never executed.  Also, the stack offset where to find on-stack arguments
was incorrect.


Modified:
    lldb/trunk/source/Plugins/ABI/SysV-s390x/ABISysV_s390x.cpp

Modified: lldb/trunk/source/Plugins/ABI/SysV-s390x/ABISysV_s390x.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/SysV-s390x/ABISysV_s390x.cpp?rev=266417&r1=266416&r2=266417&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ABI/SysV-s390x/ABISysV_s390x.cpp (original)
+++ lldb/trunk/source/Plugins/ABI/SysV-s390x/ABISysV_s390x.cpp Fri Apr 15 04:14:32 2016
@@ -365,7 +365,7 @@ ABISysV_s390x::GetArgumentValues(Thread
     if (!sp)
         return false;
 
-    addr_t current_stack_argument = sp;
+    addr_t current_stack_argument = sp + 160;
 
     uint32_t argument_register_ids[5];
 
@@ -382,7 +382,6 @@ ABISysV_s390x::GetArgumentValues(Thread
 
     unsigned int current_argument_register = 0;
 
-    return false;
     for (value_index = 0; value_index < num_values; ++value_index)
     {
         Value *value = values.GetValueAtIndex(value_index);




More information about the lldb-commits mailing list