[Lldb-commits] [PATCH] D19060: FileSpec: make matching separator-agnostic again

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 13 09:57:42 PDT 2016


Ok sounds good
On Wed, Apr 13, 2016 at 9:56 AM Pavel Labath <labath at google.com> wrote:

> labath added a comment.
>
> In http://reviews.llvm.org/D19060#399915, @zturner wrote:
>
> > Ahh that's unfortunate. I guess the thing to do is make SetFile and
> >  SetDirectory. At least by changing the return type we can get the
> compiler
> >  to tell us everywhere this is happening. Did you run the test suite on
> >  Windows to make sure this doesnt break anything?
>
>
> Yeah, I had something like that in mind.
>
> I didn't run the windows test suite, but I'd be very surprised if it broke
> anything, since I'm basically just restoring the previous behavior (before
> I started messing with this function, we were always running the
> normalization).
>
>
> http://reviews.llvm.org/D19060
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160413/a09d1966/attachment-0001.html>


More information about the lldb-commits mailing list