[Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

Ulrich Weigand via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 12 17:24:54 PDT 2016


uweigand added a comment.

In http://reviews.llvm.org/D18984#398486, @tberghammer wrote:

> Generally looks good with 2 minor comment inline. I also run the test suite on Android ARM (little endian) and everything looked fine


Thanks for the review and test!


================
Comment at: source/Plugins/Instruction/ARM/EmulationStateARM.cpp:127
@@ -119,3 +126,3 @@
         else
-            value = m_vfp_regs.d_regs[reg_num - dwarf_d16];
+            value = m_vfp_regs.d_regs[idx - 16];
     }
----------------
Good catch!  Now fixed.

================
Comment at: source/Plugins/Instruction/ARM/EmulationStateARM.cpp:157
@@ -149,12 +156,3 @@
 {
-    if (size > 8)
-        return false;
-    
-    if (size <= 4)
-        m_memory[p_address] = value;
-    else if (size == 8)
-    {
-        m_memory[p_address] = (value << 32) >> 32;
-        m_memory[p_address + 4] = value << 32;
-    }
+    m_memory[p_address] = value;
     return true;
----------------
Right, that was my intention, just forgot to actually do it ...   Now fixed.


http://reviews.llvm.org/D18984





More information about the lldb-commits mailing list