[Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 12 03:41:20 PDT 2016
labath added a comment.
Could you also add a core file test to `TestLinuxCore`? It should be a matter of running `make_core.sh`, saving the files and creating a new test function in the file (I've tried to make it simple, if you see room for improvement, then let me know).
I think this is especially important as probably noone here has access to this hardware, so this will enable the rest of the developers to run at least a basic sanity check on their changes.
Comment at: packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLocation.py:36
@@ -35,2 +35,3 @@
@expectedFailureAll(triple = re.compile('^mips')) # Most of the MIPS boards provide only one H/W watchpoints, and S/W watchpoints are not supported yet
+ @expectedFailureAll(archs=['s390x']) # SystemZ also currently supports only one H/W watchpoint
We generally expectedFailure for things which we consider an lldb bug, and skip for cases when the test simply does not apply. Platform not having enough watchpoints sounds like the latter case. I see you were simply copying the mips case (which does not follow this either), and it doesn't really matter to me, but I just wanted to make you aware of that.
More information about the lldb-commits