[Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

Jackson Davis via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 7 16:37:41 PDT 2016


jacdavis created this revision.
jacdavis added reviewers: lldb-commits, abidh.

-thread-info in lldbmi does not conform to protocol. Should end with current thread id as described here:  https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Thread-Commands.html#GDB_002fMI-Thread-Commands

When printing all threads, the current thread id should be printed afterwards. 

Example:
-thread-info
     ^done,threads=[
     {id="2",target-id="Thread 0xb7e14b90 (LWP 21257)",
        frame={level="0",addr="0xffffe410",func="__kernel_vsyscall",
                args=[]},state="running"},
     {id="1",target-id="Thread 0xb7e156b0 (LWP 21254)",
        frame={level="0",addr="0x0804891f",func="foo",
                args=[{name="i",value="10"}],
                file="/tmp/a.c",fullname="/tmp/a.c",line="158"},
                state="running"}],
     current-thread-id="1"
     (gdb)

http://reviews.llvm.org/D18880

Files:
  packages/Python/lldbsuite/test/tools/lldb-mi/threadinfo/Makefile
  packages/Python/lldbsuite/test/tools/lldb-mi/threadinfo/TestMiThreadInfo.py
  packages/Python/lldbsuite/test/tools/lldb-mi/threadinfo/test_threadinfo.cpp
  tools/lldb-mi/MICmdCmdThread.cpp
  tools/lldb-mi/MICmdCmdThread.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18880.52977.patch
Type: text/x-patch
Size: 4529 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160407/d82f2401/attachment-0001.bin>


More information about the lldb-commits mailing list