[Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

[Zachary Turner via lldb-commits]

zturner added inline comments.

================
Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:154-156
@@ +153,5 @@
+
+        CompilerType clang_type =
+            m_ast.CreateRecordType(tu_decl_ctx, access, udt->getName().c_str(), TranslateUdtKind(udt_kind),
+                                   lldb::eLanguageTypeC_plus_plus, nullptr);
+
----------------
clayborg wrote:
> If you are creating this type as a forward declaration and you want it to complete itself later, you will need to enable this with:
> 
> ```
>     m_ast.SetHasExternalStorage (ClangUtil::GetQualType(clang_type)GetOpaqueQualType(), true);
> ```
Does this mean I also need to pass `eResolveStateForward` to `Type::Type()`?


http://reviews.llvm.org/D18848