[Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting
Jim Ingham via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 1 11:07:07 PDT 2016
jingham added a subscriber: jingham.
jingham added a comment.
The only worry I have about this is
- thread A is stopped at a breakpoint, and then we stop on thread B instead, then we report a breakpoint, great!
- The user steps thread B, which we do by suspending thread B and stepping A.
- Then A stops, and we report ANOTHER hit on thread B.
Your fix looks better than what was there previously. If it is easy to check "last stop reason was this breakpoint hit, and this thread's temporary resume state is suspended, then don't report the hit, that would be more accurate.
More information about the lldb-commits