[Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

[Zachary Turner via lldb-commits]

zturner added a subscriber: zturner.
zturner added a comment.

FWIW I believe we do actually want many of the PE headers, although I have to say I don't like the format of the output.    It seems like we could break this up into smaller chunks like section headers, pe headers, binary headers, debug headers, and then allow the user to specify some combination of flags (or all) to display different levels of detail.  But that could come as a followup.  And also translate some of the hex codes to textual enum values like IMAGE_MACHINE_386 so it's easier to understand the output.

In the future we might even want a way to add operating system specific stuff to the dump.  Windows for example can have resource files embedded in them that show file version and things like that, and it's nice to get a unified view that shows some of this OS specific stuff interspersed in a nicely formatted manner.  A lot of this type of information is useful for crash reporting and bucketing


http://reviews.llvm.org/D18464