[Lldb-commits] [PATCH] D18547: Fix infinite recursion in DWO file parsing

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 29 06:28:45 PDT 2016


labath created this revision.
labath added reviewers: tberghammer, clayborg.
labath added a subscriber: lldb-commits.

Since r264316, clang started adding DW_AT_GNU_dwo_name attribute to dwo files (previously, this
attribute was only present in main object files), breaking pretty much every dwo test. The
problem was that we were treating the presence of said attribute as a signal that we should look
for information in an external object file, and caused us to enter an infinite loop. I fix this
by making sure we do not go looking for an external dwo file if we already *are* parsing a dwo
file.

http://reviews.llvm.org/D18547

Files:
  source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18547.51896.patch
Type: text/x-patch
Size: 5475 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160329/6e990185/attachment.bin>


More information about the lldb-commits mailing list