[Lldb-commits] [lldb] r263826 - Fixed an case fall through that wasn't meant to happen. Caught by clang's unannotated case fall through warning.

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 18 13:36:30 PDT 2016


Author: gclayton
Date: Fri Mar 18 15:36:30 2016
New Revision: 263826

URL: http://llvm.org/viewvc/llvm-project?rev=263826&view=rev
Log:
Fixed an case fall through that wasn't meant to happen. Caught by clang's unannotated case fall through warning.

Modified:
    lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp?rev=263826&r1=263825&r2=263826&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp Fri Mar 18 15:36:30 2016
@@ -435,15 +435,16 @@ DWARFASTParserJava::CompleteTypeFromDWAR
     switch (die.Tag())
     {
         case DW_TAG_class_type:
-        {
-            if (die.GetAttributeValueAsUnsigned(DW_AT_declaration, 0) == 0)
             {
-                if (die.HasChildren())
-                    ParseChildMembers(die, java_type);
-                m_ast.CompleteObjectType(java_type);
-                return java_type.IsValid();
+                if (die.GetAttributeValueAsUnsigned(DW_AT_declaration, 0) == 0)
+                {
+                    if (die.HasChildren())
+                        ParseChildMembers(die, java_type);
+                    m_ast.CompleteObjectType(java_type);
+                    return java_type.IsValid();
+                }
             }
-        }
+            break;
         default:
             assert(false && "Not a forward java type declaration!");
             break;




More information about the lldb-commits mailing list