[Lldb-commits] [PATCH] D18194: Abstract the debug info parser from the ASTContext

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 15 11:47:03 PDT 2016


zturner created this revision.
zturner added a reviewer: clayborg.
zturner added a subscriber: lldb-commits.

ClangASTContext was assuming the presence of DWARF debug info, so it was baked into the class that DWARFASTParserClang would be used.  This won't be the case with PDB, which will need a PDBASTParserClang.  This will be used for PDB's generated by MSVC (since it is ABI compatible with clang-cl) as well as (in the future) PDBs generated directly by clang.

For now PDBASTParserClang is not implemented, this only breaks up the DWARFASTParser class into an abstraction that is not dwarf dependent, and has ClangASTContext deal only with this abstraction, while SymbolFileDWARF can deal directly with the DWARFASTParser.

http://reviews.llvm.org/D18194

Files:
  include/lldb/Symbol/ClangASTContext.h
  include/lldb/Symbol/DebugInfoASTParser.h
  include/lldb/Symbol/GoASTContext.h
  include/lldb/Symbol/JavaASTContext.h
  include/lldb/Symbol/SymbolFile.h
  include/lldb/Symbol/TypeSystem.h
  source/Plugins/SymbolFile/DWARF/DWARFASTParser.h
  source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h
  source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
  source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
  source/Plugins/SymbolFile/PDB/SymbolFilePDB.h
  source/Symbol/ClangASTContext.cpp
  source/Symbol/GoASTContext.cpp
  source/Symbol/JavaASTContext.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18194.50760.patch
Type: text/x-patch
Size: 18485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160315/1bdf6a99/attachment-0001.bin>


More information about the lldb-commits mailing list