[Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

[Zachary Turner via lldb-commits]

zturner added a comment.

I'm waiting for the LLVM side change to go in and this patch rebased on top of that before I test it out.

In the meantime, one thing I'm concerned about is setting the codepage of the console.  You determined earlier that it affects the state of the console even after exiting LLDB.  So we clean it up on shutdown.  But what if LLDB crashes?  I'm not sure if this is a concern, but it's troublesome at the very least.

If I remember correctly, this patch was originally intended to support your use case of linking against liblldb but not using the lldb.exe driver, is that right?  Or maybe you were using the python extension module, I don't remember.  In any case, neither of those use cases requires you to display UTF8 text to the console window.  So I wonder if it is possible to do without the codepage portion of the patch.

I would like to avoid that change if at all possible, but if it is really necessary, I would at least like to do it as a separate patch, so that if need be we can revert it later without reverting the rest of the changes here.


http://reviews.llvm.org/D17107