[Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

[Greg Clayton via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

See inlined comments.


================
Comment at: packages/Python/lldbsuite/test/functionalities/expression_path/TestExpressionPath.py:44-46
@@ +43,4 @@
+			
+        self.expect('frame variable s --flat',
+                    substrs = ['s.x = 1',
+                               's.y = 2'])
----------------
Shouldn't we also see "s.r[0] = 1" and "s.r[1] = 2" in response to "frame variable s --flat"?

================
Comment at: packages/Python/lldbsuite/test/functionalities/expression_path/TestExpressionPath.py:47
@@ +46,1 @@
+                               's.y = 2'])
\ No newline at end of file

----------------
Add newline at end of file 

================
Comment at: packages/Python/lldbsuite/test/functionalities/expression_path/main.cpp:27
@@ +26,1 @@
+}
\ No newline at end of file

----------------
Add newline at end of file 


Repository:
  rL LLVM

http://reviews.llvm.org/D18005