[Lldb-commits] [PATCH] D17420: Don't use an atexit handler for cleaning up process specific temp dir

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 19 02:21:33 PST 2016


labath accepted this revision.
labath added a comment.

So, linux actually manages to invoke the atexit handlers (through some deep magic, no doubt) upon shared library unload, so we are ok here (plus linux likes to nuke /tmp after every reboot). LGTM, with a small RAII request.


================
Comment at: source/Host/common/HostInfoBase.cpp:86
@@ +85,3 @@
+{
+    CleanupProcessSpecificLLDBTempDir();
+    delete g_fields;
----------------
I think we should move this into the destructor of `g_fields`. Then you can simply do `delete g_fields` (or even `g_fields.reset()`) here.


http://reviews.llvm.org/D17420





More information about the lldb-commits mailing list