[Lldb-commits] [PATCH] D16814: Fix handling of the arm IT instruction in the unwinder

Tamas Berghammer via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 4 03:41:51 PST 2016

tberghammer added inline comments.

Comment at: include/lldb/Core/EmulateInstruction.h:390
@@ +389,3 @@
+    typedef uint32_t InstructionCondition;
+    static const InstructionCondition UnconditionalCondition = UINT32_MAX;
clayborg wrote:
> It is nice to tell when something is a constant (prefixed with "k"), a member variable (prefixed with "m_"), typenames are camel case, variables should be lower cased with underscores. That is our current coding convention.
> I would like to see this be
> ```
>     static const InstructionCondition k_unconditional_condition = UINT32_MAX;
> ```
It is a public, static member variable so I think we should use CamelCase and not snake_case and I don't see where I can add a k prefix into it (KInstructionCondition?) Also as (almost) all static member is cons inside LLDB I don't think it will be confusing


More information about the lldb-commits mailing list