[Lldb-commits] [PATCH] D16746: Use an artifical namespace so that member vars do not hide local vars.

Sean Callanan via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 3 18:26:03 PST 2016

spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.

I suggested a name change; just fix that and I think we're good to go.

Comment at: source/Symbol/ClangASTContext.cpp:1893
@@ +1892,3 @@
+    ClangASTContext *ast_ctx = ClangASTContext::GetASTContext(ast);
+    if (ast_ctx == nullptr)
We might decide later that it's not worth the work of creating an entire ClangASTContext (which has a bunch of auto_ptrs and stuff that would get initialized to no purpose) to do this work, but on the other hand we do all kinds of work doing type importing so this is likely to get lost in the noise.

If we did decide to do something about this, we'd flip it around so that the static function is the one that does the work and the non-static version calls through to the static one.

Comment at: source/Symbol/ClangASTContext.cpp:9797
@@ -9785,1 +9796,3 @@
+                                           ConstString name,
+                                           const bool ignore_imported_decls)
The //ignore_imported_decls// parameter would probably be better off being called //ignore_using_decls//.  That makes it more clear what's happening.


More information about the lldb-commits mailing list