[Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Wed Feb 3 14:55:32 PST 2016
I ahad 3 CLs in progress locally and I guess I messed up a merge. There's
supposed to be a subprocess.PIPE instead of just PIPE. I'll check in a fix
On Wed, Feb 3, 2016 at 2:51 PM Siva Chandra <sivachandra at google.com> wrote:
> This change broke Android testsuite run:
> On Wed, Feb 3, 2016 at 11:20 AM, Zachary Turner via lldb-commits
> <lldb-commits at lists.llvm.org> wrote:
> > zturner added a comment.
> > In http://reviews.llvm.org/D16830#343232, @zturner wrote:
> >> In http://reviews.llvm.org/D16830#342842, @tberghammer wrote:
> >> > Looks reasonable and I agree with Pavel in the idea of moving the
> android related utility functions into their own file for better separation
> >> I thought about creating an android specific module but I decided taht
> there is so little code right now it might not make sense. And then we
> already had this lldbplatformutil file that had only 1 function in it, so
> nobody was even really using it. So rather than end up with 2 different
> modules with 3 functions each, just have just have 1 module with 6
> functions. On the other hand, if they continue to grow, then splitting
> apart makes a lot of sense.
> >> It's not a big deal to me either way, so if you guys feel strongly I
> can move it. Since you're in a different time zone though and might not
> get this for another 24 hours, maybe I'll commit like this and then if you
> > (somehow my previous message got cut off).
> > if you want it changed let me know and I'll move it to an
> android-specific file tomorrow.
> > Repository:
> > rL LLVM
> > http://reviews.llvm.org/D16830
> > _______________________________________________
> > lldb-commits mailing list
> > lldb-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits