[Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 3 10:20:09 PST 2016

zturner marked 2 inline comments as done.
zturner added a comment.

In http://reviews.llvm.org/D16830#342842, @tberghammer wrote:

> Looks reasonable and I agree with Pavel in the idea of moving the android related utility functions into their own file for better separation

I thought about creating an android specific module but I decided taht there is so little code right now it might not make sense.  And then we already had this lldbplatformutil file that had only 1 function in it, so nobody was even really using it.  So rather than end up with 2 different modules with 3 functions each, just have just have 1 module with 6 functions.  On the other hand, if they continue to grow, then splitting apart makes a lot of sense.

It's not a big deal to me either way, so if you guys feel strongly I can move it.  Since you're in a different time zone though and might not get this for another 24 hours, maybe I'll commit like this and then if you


More information about the lldb-commits mailing list