[Lldb-commits] [PATCH] D16741: Make many of the skip decorators use common code

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 2 08:02:23 PST 2016

tfiala added a comment.

> We've already had a case when a test wasn't running for several months

before I noticed (see r257901) that it had a bad decorator applied at the
class level.

I've been thinking about this in the background lately.  Several times over
the last couple years I found decorator logic that had errors in them
(literally, the code was throwing an exception within the decorator logic,
such as using a module that isn't imported), but this will go by silently
unless some work is put into logging errors there.

If we haven't already, we should probably have some kind of exception
wrapper around our decorators that catches non-unittest-related (i.e.
unexpected) exceptions and somehow makes them more prevalent - maybe a hard
error on the test or an abort or something.


More information about the lldb-commits mailing list