[Lldb-commits] [PATCH] D16703: Fix TestDataFormatterScript for Linux.

Enrico Granata via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 28 21:24:58 PST 2016


granata.enrico added a comment.

That seems reasonable, yes.

In general, I wish I had done this not via two strings - only one of which gets to be valid in some arbitrary order - but via either two distinct subclasses, or at least via a pair of a string and an enum class specifying the kind.

But that is clearly beyond the scope of you fixing this test case. Your change is fine.


Repository:
  rL LLVM

http://reviews.llvm.org/D16703





More information about the lldb-commits mailing list