[Lldb-commits] [PATCH] D16397: [LLDB] Consider only valid symbols while resolving by address

[Adrian McCarthy via lldb-commits]

amccarth added a subscriber: amccarth.
amccarth added a comment.

This patch  broke approximately 10 tests on Windows, mostly related to thread step-over, thread step-out, etc.  We probably  need to fix something in PECOFF::GetSymTab that's causing all the symbols to be rejected.  I'll look into it more.


================
Comment at: lldb/trunk/source/Symbol/Symtab.cpp:1077
@@ -1076,1 +1076,3 @@
 void
+Symtab::ForEachSymbolContainingFileAddresss (addr_t file_addr, std::function <bool(Symbol *)> const &callback)
+{
----------------
Addresss has too many `s`s.

================
Comment at: lldb/trunk/source/Symbol/Symtab.cpp:1092
@@ +1091,3 @@
+        if (!callback(SymbolAtIndex(all_addr_indexes[i])))
+        break;
+    }
----------------
Indentation problem.


Repository:
  rL LLVM

http://reviews.llvm.org/D16397