[Lldb-commits] [PATCH] D16322: Enable test log collection from remote debug servers

[Todd Fiala via lldb-commits]

tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.

Looks reasonable.

I added one question on whether we can get a warning on failure to retrieve the server.log file when expecting one and it doesn't show up (perhaps only in verbose mode), which is totally not needed for this patch.

There's also one minor comment fix.


================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1380
@@ +1379,3 @@
+        # Retrieve the server log (if any) from the remote system. It is assumed the server log
+        # is writting to the "server.log" file in the current test directory. This can be
+        # achieved by setting LLDB_DEBUGSERVER_LOG_FILE="server.log" when starting remote
----------------
minor: s/writting/writing/

================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1385-1386
@@ +1384,4 @@
+            # This is executed on a best-effort basis. If the file is not there, so be it.
+            lldb.remote_platform.Get(lldb.SBFileSpec("server.log"),
+                    lldb.SBFileSpec(self.getLogBasenameForCurrentTest()+"-server.log"))
+
----------------
It might be nice to get some kind of output (perhaps in verbose mode?) if we're expecting the server.log to be there but we fail to retrieve it.  (Just a warning).  Does lldb.remote_platform.Get() already do that on a failure?


http://reviews.llvm.org/D16322