[Lldb-commits] [PATCH] D16293: [cmake] Make dependencies of lldb libraries private

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 21 07:36:32 PST 2016


labath added a comment.

I think a similar command as for argdumper would fix this (probably `target_link_libraries(lldb, lldbHost)`). I thought about doing that instead, but then I realised that netbsd probably needs this as well, and lldb-mi seems to be using getopt also, etc. So I figured I'll make this as surgical as possible, and enable the fix on linux only.

When this gets into 3.8, I will add a separate patch, which sets the private keyword everywhere, getopt (through lldbHost) to lldb and lldb-mi on relevant platforms. How does that sound?


http://reviews.llvm.org/D16293





More information about the lldb-commits mailing list