[Lldb-commits] [PATCH] D16128: Fix TestProcessLaunch.test_environment_with_special_char for Python 3

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 13 08:22:07 PST 2016


labath added a comment.

In http://reviews.llvm.org/D16128#325804, @zturner wrote:

> Yea, supporting GetStdio is really difficult on Windows.  We might try to do it again someday.  Putting it in a char[] variable and reading the variable seems like a decent solution, I will try that.


Thanks.

> There's lots of tests currently that redirect stdio, are those all broken on Linux currently?


The redirection works on linux, it's just not 100% reliable in tests. The thing is that inferior stdio arrives asynchronously wrt. everything else, so you really cannot be sure that by the time you do GetSTDOUT(), all output will be available. It works most of the time, but it fails in like ~0.1% of cases -- not much, but enough to be annoying when scrutinizing buildbot failures.


http://reviews.llvm.org/D16128





More information about the lldb-commits mailing list