[Lldb-commits] [PATCH] D16125: [TestThreadJump] Adjust match sub-string after recent change.

[Zachary Turner via lldb-commits]

This isn't going to work either, because Windows doesn't the name=
portion.  God I really hate these tests that do substring matching.

I guess there's no easy way to guarantee that the main.cpp:<line-number> is
on the same frame as the breakpoint.  Can you change it to:

substrs = ['stopped',
    'main.cpp:{}'.format(self.mark3),
    'stop reason = breakpoint 1'
]

On Tue, Jan 12, 2016 at 2:14 PM Siva Chandra <sivachandra at google.com> wrote:

> sivachandra created this revision.
> sivachandra added a reviewer: zturner.
> sivachandra added a subscriber: lldb-commits.
>
> http://reviews.llvm.org/D16125
>
> Files:
>
> packages/Python/lldbsuite/test/functionalities/thread/jump/TestThreadJump.py
>
> Index:
> packages/Python/lldbsuite/test/functionalities/thread/jump/TestThreadJump.py
> ===================================================================
> ---
> packages/Python/lldbsuite/test/functionalities/thread/jump/TestThreadJump.py
> +++
> packages/Python/lldbsuite/test/functionalities/thread/jump/TestThreadJump.py
> @@ -34,7 +34,7 @@
>          # The stop reason of the thread should be breakpoint 1.
>          self.expect("thread list", STOPPED_DUE_TO_BREAKPOINT + " 1",
>              substrs = ['stopped',
> -                       'main.cpp:{}, stop reason = breakpoint
> 1'.format(self.mark3)])
> +                       "main.cpp:{0}, name = '{1}', stop reason =
> breakpoint 1".format(self.mark3, os.path.basename(exe))])
>
>          self.do_min_test(self.mark3, self.mark1, "i", "4"); # Try the int
> path, force it to return 'a'
>          self.do_min_test(self.mark3, self.mark2, "i", "5"); # Try the int
> path, force it to return 'b'
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160112/506ab609/attachment.html>