[Lldb-commits] [PATCH] D16017: Fix TestMiniDump.py for Python 3

[Zachary Turner via lldb-commits]

zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D16017#323550, @amccarth wrote:

> In http://reviews.llvm.org/D16017#322830, @zturner wrote:
>
> > What's the extra frame?  Why does Python have an effect on the number of
> >  frames seen by the minidump?  Something seems wrong about that.
>
>
> Sorry, I misspoke.  It has nothing to do with the version of Python.  There's a new frame showing below main:
>
> > - thread #1: tid = 0x0454, 0x0004a00c a.out`int bar(x=3) + 12 at main.cpp:6, stop reason = breakpoint 1.1
>
> >   - frame #0: 0x0004a00c a.out`int bar(x=3) + 12 at main.cpp:6 frame #1: 0x0004a048 a.out`int foo(x=3) + 24 at main.cpp:13 frame #2: 0x0004a081 a.out`main + 33 at main.cpp:20 frame #3: 0x0004a49c a.out`$LN27 + 224
>
>
> I suppose this might be from a change to the linker or the generation of debug info.  Originally, the deepest frame that showed was main.


Meh.  This reminds me of why I wanted to check in the dump file.  We're seeing different call stacks with different compilers.  But I guess this is fine.


http://reviews.llvm.org/D16017