[Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 7 19:09:02 PST 2016


jingham added a comment.

Cool!  For completeness I think it is a good idea to do this to all the functions in InferiorCallPOSIX.  For the general InferiorCall one it might be a good idea to add a defaulted (to false) parameter so that if somebody really needs to use it for something that might throw they can.  But this is for calling simple low level function which shouldn't be throwing, so defaulting to not firing up the runtimes to catch exceptions is more appropriate.

Then this is good to go.


http://reviews.llvm.org/D15978





More information about the lldb-commits mailing list