[Lldb-commits] [PATCH] D15886: [LLDB][MIPS32]Merge emulation of similar instructions

[Pavel Labath via lldb-commits]

labath added a subscriber: labath.
labath added a comment.

Hi, this introduces loads of new compiler warnings like:

  lldb/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:1434:14: warning: variable 'target' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
      else if (!strcasecmp (op_name, "BNE") ||
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  lldb/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:1447:77: note: uninitialized use occurs here
      if (!WriteRegisterUnsigned (context, eRegisterKindDWARF, dwarf_pc_mips, target))
                                                                              ^~~~~~
  lldb/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:1434:10: note: remove the 'if' if its condition is always true
      else if (!strcasecmp (op_name, "BNE") ||
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  lldb/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:1407:31: note: initialize the variable 'target' to silence this warning
      int32_t offset, pc, target, rs_val, rt_val;
                                ^
                                 = 0

Could you please resolve these?


Repository:
  rL LLVM

http://reviews.llvm.org/D15886