[Lldb-commits] [PATCH] D15893: Adds expectedFailureArmLinux test decorator

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 5 10:10:01 PST 2016


clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Seems like it would be better to mimic how @expectedFailureAndroid works. See inlined comments.


================
Comment at: packages/Python/lldbsuite/test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py:20
@@ -19,2 +19,3 @@
     @expectedFailureAndroid(archs=['arm', 'aarch64']) # Watchpoints not supported
+    @expectedFailureArmLinux("llvm.org/pr26031")
     @expectedFailureWindows("llvm.org/pr24446")
----------------
Seems like it would be better to do things like @expectedFailureAndroid that is just above:

```
 @expectedFailureLinux(archs=['arm'], bug="llvm.org/pr26031")
```

I would like to avoid having new variants of the @expectedFailure that contain the architecture in the name.


http://reviews.llvm.org/D15893





More information about the lldb-commits mailing list