[Lldb-commits] [PATCH] D15530: [test] Add ability to expect timeouts

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 15 14:18:16 PST 2015


tfiala added a comment.

Hey Pavel,

Change r255676 changed a few things that will require this patch to get updated.  I think the main code change will be that ResultsFormatter._make_rerun_eligibility_key(self) has been renamed to ResultsFormatter._make_key(self).  I folded the BasicResultsFormatter class into ResultsFormatter since any specialized results formatters still likely want to display the results summary output at the end.  That key is now used in several places and they're not at all specific to rerun eligibility.

The rest of the differences are likely just line number changes as the new code here will just need to slide into different final spots in the now top-of-tree version of result_formatter.py.

Thanks, and sorry for the collision!


http://reviews.llvm.org/D15530





More information about the lldb-commits mailing list