[Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

[Siva Chandra via lldb-commits]

On Mon, Dec 14, 2015 at 6:42 PM, Zachary Turner <zturner at google.com> wrote:
> zturner added inline comments.
>
> ================
> Comment at: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py:622
> @@ -621,3 +621,3 @@
>          return list_or_lambda(value)
> -    elif isinstance(list_or_lambda, list):
> -        return list_or_lambda is None or value is None or value in list_or_lambda
> +    elif isinstance(list_or_lambda, list) or isinstance(list_or_lambda, str):
> +        return value is None or value in list_or_lambda
> ----------------
> I mentioned this in the other thread, but I'm not sure we want the string check.  if `list_or_lambda` is a string, then I think it should just check `list_or_lambda == value`.  Otherwise the test only passes when `value` is a character, which is not now we use any of the decorators.

AFAIK, there is no character type in Python. The code 'value in
list_or_lambda' returns True if |value| is a substring of
|list_or_lambda|. For example, 'db' in 'lldb' evaluates to True.