[Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

Ed Maste via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 14 07:00:59 PST 2015


emaste added inline comments.

================
Comment at: source/Plugins/Process/Utility/CMakeLists.txt:6
@@ -5,2 +5,3 @@
   FreeBSDSignals.cpp
+  NetBSDSignals.cpp
   GDBRemoteSignals.cpp
----------------
Should keep these in alpha order

================
Comment at: source/Target/UnixSignals.cpp:66
@@ -64,4 +65,3 @@
         case llvm::Triple::FreeBSD:
         case llvm::Triple::OpenBSD:
             return std::make_shared<FreeBSDSignals>();
----------------
Not part of your change, but just spotted it during this review; The default case should probably be used for OpenBSD. We can change it later.


Repository:
  rL LLVM

http://reviews.llvm.org/D15482





More information about the lldb-commits mailing list